Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various mixture-related fluid properties improvements #29754

Draft
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

joshuahansel
Copy link
Contributor

This PR does the following, in support of the upcoming THM gas mixture flow channel:

  • Added default implementations for SinglePhaseFluidProperties::criticalDensity() and criticalInternalEnergy() by evaluating respective methods with criticalPressure() and criticalTemperature().
  • Closes Fluid properties interrogator does not report invalid properties combination for corner case #29656
  • Stopped outputting vapor mixture properties twice in FluidPropertiesInterrogator
  • Added debug information to the solve-failed exception in BrentsMethod (iteration history)
  • Added REL_ABS_TEST macro to FluidPropertiesTestUtils
  • Added s(p,T) to VaporMixtureFluidProperties and interrogator
  • Went nuts on cleaning up IdealRealGasMixtureFluidProperties and its Test
  • Added warnings in IdealRealGasMixtureFluidProperties where derivatives have been neglected
  • Added methods to IdealRealGasMixtureFluidProperties for getting the primary and secondary fluid properties objects

@joshuahansel joshuahansel self-assigned this Jan 27, 2025
@moosebuild
Copy link
Contributor

Job Documentation, step Docs: sync website on ba794d0 wanted to post the following:

View the site here

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fluid properties interrogator does not report invalid properties combination for corner case
2 participants