Fix for skipped sync timesteps in exodus files #29771
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Because of floating point errors _time did would be off from _sync_time by less than 1e-15 - Replaced find function with a difference comparison between _sync_time, _time, and _t_tol closes idaholab#28722
|
Job Documentation, step Docs: sync website on cb31893 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage, step Generate coverage on cb31893 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
|
did you run the input from the discussions? can you please PM me the exodus file if so so I can check the steps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
sync_timesworks as intendedDesign
_sync_timeby less than 1e-15_sync_time,_time, and_t_tolImpact
closes #28722