Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted deprecated closures member #29778

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Deleted deprecated closures member #29778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions modules/thermal_hydraulics/include/components/FlowChannelBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@ class FlowChannelBase : public Component1D, public GravityInterface
*
* @return The closures object(s)
*/
std::shared_ptr<ClosuresBase> getClosures() const
{
mooseDeprecated("getClosures() is deprecated. Use getClosuresObjects() instead.");
return _closures;
}
std::vector<std::shared_ptr<ClosuresBase>> getClosuresObjects() const
{
return _closures_objects;
Expand Down Expand Up @@ -221,7 +216,6 @@ class FlowChannelBase : public Component1D, public GravityInterface
FunctionName _area_function;

/// Closures object(s)
std::shared_ptr<ClosuresBase> _closures;
std::vector<std::shared_ptr<ClosuresBase>> _closures_objects;

const bool & _pipe_pars_transferred;
Expand Down
1 change: 0 additions & 1 deletion modules/thermal_hydraulics/include/components/HeatTransferBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ class HeatTransferBase : public ConnectorBase
const bool _P_hf_provided;

/// Used closures object(s)
std::shared_ptr<ClosuresBase> _closures;
std::vector<std::shared_ptr<ClosuresBase>> _closures_objects;

/// heated perimeter name
Expand Down
3 changes: 0 additions & 3 deletions modules/thermal_hydraulics/src/components/FlowChannelBase.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,6 @@ FlowChannelBase::init()
const auto & closures_names = getParam<std::vector<std::string>>("closures");
for (const auto & closures_name : closures_names)
_closures_objects.push_back(getTHMProblem().getClosures(closures_name));
// _closures should be removed after transition:
if (_closures_objects.size() >= 1)
_closures = _closures_objects[0];
}
}

Expand Down
1 change: 0 additions & 1 deletion modules/thermal_hydraulics/src/components/HeatTransferBase.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ HeatTransferBase::init()
_model_type = flow_channel.getFlowModelID();
_fp_name = flow_channel.getFluidPropertiesName();
_A_fn_name = flow_channel.getAreaFunctionName();
_closures = flow_channel.getClosures();
_closures_objects = flow_channel.getClosuresObjects();
}
}
Expand Down