Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add app info to exodus output #29786

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

DanielYankura
Copy link
Contributor

Reason

  • More info for debugging

Design

  • n_processors, n_threads, and app name is now included in the input file included in the exodus output file

Impact

  • adds additional data to exodus output

closes #29767

@GiudGiud GiudGiud self-assigned this Feb 1, 2025
@GiudGiud
Copy link
Contributor

GiudGiud commented Feb 1, 2025

we could just be consistent with the console and use this

std::string
outputFrameworkInformation(const MooseApp & app)

from ConsoleUtils

EDIT: now that I think about I dont want that. I m already on the fence for num processes though I dont have a strong opinion.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 1, 2025

Job Documentation, step Docs: sync website on 37650a7 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 1, 2025

Job Coverage, step Generate coverage on 37650a7 wanted to post the following:

Framework coverage

32662f #29786 37650a
Total Total +/- New
Rate 85.23% 85.23% -0.00% 100.00%
Hits 108490 108493 +3 5
Misses 18794 18795 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@DanielYankura DanielYankura force-pushed the add_app_version_to_exodus branch from b9fa0a5 to 6575156 Compare February 3, 2025 15:08
@GiudGiud
Copy link
Contributor

GiudGiud commented Feb 3, 2025

Let’s squash these two commits together

- n_processors, n_threads, and app name is now included in the input file included in the exodus output file

closes idaholab#29767
@DanielYankura DanielYankura force-pushed the add_app_version_to_exodus branch from 6575156 to 37650a7 Compare February 3, 2025 15:57
@GiudGiud GiudGiud merged commit 7bda5ab into idaholab:next Feb 6, 2025
51 checks passed
@vincentlaboure
Copy link
Contributor

Thanks @DanielYankura and @GiudGiud !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write the app's version into the Exodus outputs it produces
4 participants