Skip to content

Add fuel cycle diagram utility. #Close 445 - #446

Open
ke7kto wants to merge 2 commits into
idaholab:develfrom
ke7kto:fc_diagram
Open

Add fuel cycle diagram utility. #Close 445#446
ke7kto wants to merge 2 commits into
idaholab:develfrom
ke7kto:fc_diagram

Conversation

@ke7kto

@ke7kto ke7kto commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

#closes #445

Reason

User-friendliness improvement allowing visualization of scalar systems modeling

Design

Simple python script creating svg block diagrams. This PR was developed with AI assistance.

Impact

Add something new

@simopier simopier self-assigned this Aug 6, 2026
@simopier simopier added the PR: AI assisted Pull requests that utilized AI in their development label Aug 6, 2026

@simopier simopier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great contribution! Thank you @ke7kto!

A few suggestions:

  • add some of the properties of the dependencies along the arrows (like fraction of the inventory going along this particular dependency)
  • I am not seeing the figure right now, but did you also illustrate the losses (along with the parameter value associated with it)?
  • output also in pdf and png formats
  • try to reduce the number of arrows crossing path

Also, could you apply this to the Meschini? You might need to use the right input file syntax for this model too, but I think it would be valuable to show it works on any fuel cycle model.

I will need to double check a few things once CIVET is back and the documentation builds:

  • check the esthetic of the figure more
  • make sure the graph accurately illustrates the fuel cycle and that there are no mistakes

Comment thread doc/content/examples/fuel_cycle_Abdou/index.md Outdated
Comment thread test/tests/fuel_cycle_Abdou/tests Outdated


# --------------------------------------------------------------------------
# 4. Geometry / collision helpers

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Methods in this section could benefit from some comments to explain what they do and how they serve the broader capability.

@simopier

Copy link
Copy Markdown
Collaborator

@ke7kto you need to list the issue number in one of your commits:

##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'fc_diagram' of https://github.com/ke7kto/TMAP8 into test
Add fuel cycle diagram utility. #Close 445
##########################################################################

@ke7kto

ke7kto commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

@ke7kto you need to list the issue number in one of your commits:

##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'fc_diagram' of https://github.com/ke7kto/TMAP8 into test
Add fuel cycle diagram utility. #Close 445
##########################################################################

The git commit message included #Close 445, does that need to be #Closes #445?

Apply suggestions from code review.

Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>
@moosebuild

Copy link
Copy Markdown

Job Precheck, step Python: black format on f56665e wanted to post the following:

Python black formatting

Your code requires style changes.

A patch was generated and copied here.

You can directly apply the patch by running the following at the top level of your repository:

curl -s https://mooseframework.inl.gov/tmap8/docs/PRs/446/black/black.patch | git apply -v

Alternatively, you can run the following at the top level of your repository:

black --config pyproject.toml --workers 1 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: AI assisted Pull requests that utilized AI in their development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuel Cycle Diagram Utility

3 participants