Add fuel cycle diagram utility. #Close 445 - #446
Conversation
simopier
left a comment
There was a problem hiding this comment.
This is a great contribution! Thank you @ke7kto!
A few suggestions:
- add some of the properties of the dependencies along the arrows (like fraction of the inventory going along this particular dependency)
- I am not seeing the figure right now, but did you also illustrate the losses (along with the parameter value associated with it)?
- output also in pdf and png formats
- try to reduce the number of arrows crossing path
Also, could you apply this to the Meschini? You might need to use the right input file syntax for this model too, but I think it would be valuable to show it works on any fuel cycle model.
I will need to double check a few things once CIVET is back and the documentation builds:
- check the esthetic of the figure more
- make sure the graph accurately illustrates the fuel cycle and that there are no mistakes
|
|
||
|
|
||
| # -------------------------------------------------------------------------- | ||
| # 4. Geometry / collision helpers |
There was a problem hiding this comment.
Methods in this section could benefit from some comments to explain what they do and how they serve the broader capability.
|
@ke7kto you need to list the issue number in one of your commits: |
The git commit message included |
Apply suggestions from code review. Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>
|
Job Precheck, step Python: black format on f56665e wanted to post the following: Python black formattingYour code requires style changes. A patch was generated and copied here. You can directly apply the patch by running the following at the top level of your repository: Alternatively, you can run the following at the top level of your repository: |
#closes #445
Reason
User-friendliness improvement allowing visualization of scalar systems modeling
Design
Simple python script creating svg block diagrams. This PR was developed with AI assistance.
Impact
Add something new