Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI deployment config #4

Merged
merged 2 commits into from
Dec 8, 2016
Merged

Fix CI deployment config #4

merged 2 commits into from
Dec 8, 2016

Conversation

anggiaj
Copy link
Collaborator

@anggiaj anggiaj commented Dec 8, 2016

Masalahnya:

Benerinnya:

Website repository of id.js.org

[![CircleCI](https://circleci.com/gh/idjs/idjs.github.io/tree/development.svg?style=svg)](https://circleci.com/gh/idjs/idjs.github.io/tree/development)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Biar tau build process-nya berhasil atau gagal

@@ -71,3 +71,6 @@ deploy:
type: git
repo: https://github.com/idjs/idjs.github.io
branch: master
name: idjs
email: [email protected]
message: 'Site updated: {{ now(\'YYYY-MM-DD HH:mm:ss\') }} [ci skip]'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ci skip] biar si CircleCI gak nge-build master toh nanti isinya cuma hasil build https://circleci.com/docs/skip-a-build/

dependencies:
post:
- npm install -g hexo
- ./node_modules/.bin/hexo deploy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gak perlu install hexo global, di package.json udah ada local hexo, tinggal pake

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ini bisa dirapikan harusnya dengan npm script, di package.json buat script misal deploy isi command-nya hexo deploy, run nya npm run deploy. Script di package.json alias npm script aware dengan local installation package.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anggiaj
Copy link
Collaborator Author

anggiaj commented Dec 8, 2016

Tambahan (buat mimin), branch default ganti ke development aja, biar ntar kalo PR, gak salah ke master

@hellowin
Copy link
Contributor

hellowin commented Dec 8, 2016

@anggiaj latest changes mau di master apa development? Kalau di open sources JS umum master itu justru yg kotor, yang stabil di lock per publish atau tag pake prefix v misal tag v1.0.0 berarti rilis versi 1.0.0. Tapi ini bebas sesuai kesepakatan aja.

@hellowin hellowin merged commit 7ea55d2 into development Dec 8, 2016
@hellowin hellowin deleted the fix/deployment-config branch December 8, 2016 14:35
@anggiaj
Copy link
Collaborator Author

anggiaj commented Dec 8, 2016

@hellowin kita gak bisa pake master, soalnya github page untuk org butuh master-nya, kalo mo pake master kita harus pake pendekatan 2 repo

@hellowin
Copy link
Contributor

hellowin commented Dec 9, 2016

@anggiaj iya ternyata, ini gara2 config gh-pages nya ga bisa diubah dari master, biasanya pages itu di gh-pages bukan master.

@anggiaj
Copy link
Collaborator Author

anggiaj commented Dec 9, 2016

https://help.github.com/articles/user-organization-and-project-pages/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants