Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
download_github_licenseonly triesmainandmasterfor the LICENSE file. Repos whose default branch issomething else (e.g.
inab/trimalontrimAl,samtools/bcftoolsondevelop) fall through to the not-found error even when the file is present at HEAD. This queries the GitHub API for therepo's actual default branch and tries that first, then falls back to main/master. Non-breaking — existing main/master repos hit a single extra API call before the same raw fetch.
Merge order
sbom-implementationis the priority branch and rewrites parts of the builders. This PR conflicts with it onhub/builders/builder.py. Rebase after it lands.Still needed after that: master hardcodes
["main", "master"]when fetching a licence, which fails for repositories whose default branch is neither —inab/trimalusestrimAl.