fix(smoke): support separate actuator target - #689
Open
ShinyHero666 wants to merge 1 commit into
Open
Conversation
Signed-off-by: ShinyHero666 <160204855+ShinyHero666@users.noreply.github.com>
ShinyHero666
force-pushed
the
fix/627-split-smoke-targets
branch
from
August 5, 2026 04:13
baa0f20 to
382cd50
Compare
FenjuFu
approved these changes
Aug 5, 2026
FenjuFu
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the split-target behavior and regression coverage. ACTUATOR_BASE_URL preserves the existing default, both Actuator probes use the private target when configured, HTML SPA fallbacks are rejected, and the application API checks remain on BASE_URL. The focused shell tests plus full CI, DCO, and CLA are green. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ACTUATOR_BASE_URL, while preserving the current single-URL default.Validation
Commands run:
Risk
ACTUATOR_BASE_URLdefaults to the existing public/API target.Notes