cleanup proptests with *_strat fns

[Johnnycus]

No description provided.

[billythedummy]

i missed describing this in the issue but actly i'd wanted to refactor the tests of all the individual instructions to have a single universal test fn that takes few args. set_admin_test is a good example where it takes the bare min of the instruction, accounts and expected error. Some instructions (or instruction chain in rebalance's case) may need more args - for eg test fn for swap instructions should probably take a Quote as an arg that it can check against.

The reason for doing this is just bec i thought i'd landed on a nice clean understandable pattern there, but lmk if it isnt the case in your opinion or you have suggestions for improvement

We can do this in separate PRs, maybe 1 PR for each instruction

[billythedummy]

Some instructions (or instruction chain in rebalance's case) may need more args - for eg test fn for swap instructions should probably take a Quote as an arg that it can check against

you can probably express different set of checks to run on success vs on error using a Result type lul like Result<Quote, ProgramError>

[Johnnycus]

i missed describing this in the issue but actly i'd wanted to refactor the tests of all the individual instructions to have a single universal test fn that takes few args. set_admin_test is a good example where it takes the bare min of the instruction, accounts and expected error. Some instructions (or instruction chain in rebalance's case) may need more args - for eg test fn for swap instructions should probably take a Quote as an arg that it can check against.

The reason for doing this is just bec i thought i'd landed on a nice clean understandable pattern there, but lmk if it isnt the case in your opinion or you have suggestions for improvement

We can do this in separate PRs, maybe 1 PR for each instruction

i like that pattern, think we can stick with it. let's make a PR per group of ix tests like: admin, disable_pool, liquidity, protocol_fee, rebalance, swap, sync_sol_value?