Add FFI helpers #156
Merged
Add FFI helpers #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelmarnk
commented
Dec 27, 2025
abelmarnk
commented
Dec 27, 2025
Contributor
billythedummy
left a comment
billythedummy
left a comment
There was a problem hiding this comment.
thank you for the effort
Contributor
Author
|
Thanks for the review, I've made the changes. |
abelmarnk
commented
Dec 28, 2025
Contributor
billythedummy
left a comment
billythedummy
left a comment
There was a problem hiding this comment.
just some nits and then whatever the newly approved CI run catches
Co-authored-by: Han Yang <[email protected]>
Co-authored-by: Han Yang <[email protected]>
Contributor
Author
|
@billythedummy Thanks for new review, I've made the changes. |
Contributor
billythedummy
left a comment
billythedummy
left a comment
There was a problem hiding this comment.
pretty much good to go, just the clippy thing. Thank you!
Contributor
Author
Fixed! |
billythedummy
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the FFI helpers from #101, as well as tests for them.
It also corrects tests for two of the already written helpers.
cc: @billythedummy