-
Notifications
You must be signed in to change notification settings - Fork 18
docs: fix README CI badges ,and links #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
#' was downloaded from | ||
#' <http://vlado.fmf.uni-lj.si/pub/networks/data/bio/foodweb/foodweb.htm>. | ||
#' was downloaded from the then webpage of the Pajek software | ||
#' (link now broken). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not write "link now broken" in the documentation.
In this case, Google still finds the page and there is only a timeout. This suggests that the server is only down temporarily and will come back.
When this is not the case, it is best to get the last good snapshot of the page from archive.org. To do this, one needs the original link, another argument not to remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my case the webpage never loaded. Do you want to link to the archive.dot snapshots for broken links then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a snapshot for this page on the wayback machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think we should wait for a couple of days and see if comes back online (or just email Vlado and ask).
That said, this page is present on the Wayback Machine and the datasets are downloadable:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind emailing Vlado? It'd be nice to link to an https not http page. 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly reminder 😁
#' Innovative Technology Administration (RITA). See | ||
#' <http://www.rita.dot.gov/about_rita/> for details. The airport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@szhorvat a big issue is that CRAN will flag broken link even if they're not formatted as links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this wikipedia page as a link to the web archive link of the RITA.
This only fix broken links and add a few DOIs but only for foodwebs for now. I have not looked for URLs for theses. Do we want to do that, with the risk that these URLs change a lot? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
===========================================
- Coverage 100.00% 1.97% -98.03%
===========================================
Files 1 2 +1
Lines 3 152 +149
===========================================
Hits 3 3
- Misses 0 149 +149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -55,7 +55,7 @@ you use this data set: | |||
|
|||
D. Gfeller, Simplifying complex networks: from a clustering to a | |||
coarse graining strategy, \emph{PhD Thesis EPFL}, no 3888, 2007. | |||
http://library.epfl.ch/theses/?nr=3888 | |||
https://doi.org/10.5075/epfl-thesis-3888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really pleased that this thesis has a DOI, I should check for the other theses.
I found no other DOIs for this PR. |
Fix #31
Not ready yet