Skip to content

docs: fix README CI badges ,and links #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Apr 28, 2025

Fix #31

Not ready yet

#' was downloaded from
#' <http://vlado.fmf.uni-lj.si/pub/networks/data/bio/foodweb/foodweb.htm>.
#' was downloaded from the then webpage of the Pajek software
#' (link now broken).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not write "link now broken" in the documentation.

In this case, Google still finds the page and there is only a timeout. This suggests that the server is only down temporarily and will come back.

When this is not the case, it is best to get the last good snapshot of the page from archive.org. To do this, one needs the original link, another argument not to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my case the webpage never loaded. Do you want to link to the archive.dot snapshots for broken links then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find a snapshot for this page on the wayback machine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case I think we should wait for a couple of days and see if comes back online (or just email Vlado and ask).

That said, this page is present on the Wayback Machine and the datasets are downloadable:

https://web.archive.org/web/20230930092030/http://vlado.fmf.uni-lj.si/pub/networks/data/bio/foodweb/foodweb.htm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind emailing Vlado? It'd be nice to link to an https not http page. 😸

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly reminder 😁

#' Innovative Technology Administration (RITA). See
#' <http://www.rita.dot.gov/about_rita/> for details. The airport
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szhorvat a big issue is that CRAN will flag broken link even if they're not formatted as links.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this wikipedia page as a link to the web archive link of the RITA.

@maelle maelle marked this pull request as ready for review April 28, 2025 08:41
@maelle
Copy link
Contributor Author

maelle commented Apr 28, 2025

This only fix broken links and add a few DOIs but only for foodwebs for now. I have not looked for URLs for theses. Do we want to do that, with the risk that these URLs change a lot?

Copy link

codecov bot commented Apr 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.97%. Comparing base (81d5cec) to head (d39940c).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (81d5cec) and HEAD (d39940c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (81d5cec) HEAD (d39940c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #35       +/-   ##
===========================================
- Coverage   100.00%   1.97%   -98.03%     
===========================================
  Files            1       2        +1     
  Lines            3     152      +149     
===========================================
  Hits             3       3               
- Misses           0     149      +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -55,7 +55,7 @@ you use this data set:

D. Gfeller, Simplifying complex networks: from a clustering to a
coarse graining strategy, \emph{PhD Thesis EPFL}, no 3888, 2007.
http://library.epfl.ch/theses/?nr=3888
https://doi.org/10.5075/epfl-thesis-3888
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really pleased that this thesis has a DOI, I should check for the other theses.

@maelle
Copy link
Contributor Author

maelle commented Apr 29, 2025

I found no other DOIs for this PR.

@maelle maelle mentioned this pull request Apr 29, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update links to original data sources
2 participants