fix: improve netzschleuder internals #40
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
reviewed
May 13, 2025
| @@ -129,10 +133,10 @@ ns_metadata <- function(name, collection = FALSE) { | |||
| "i" = "see {.url {collection_url}}" | |||
| ) | |||
| ) | |||
| } else if (net_ident[[1]] == net_ident[[2]]) { | |||
| } else if (net_ident[["collection"]] == net_ident[["network"]]) { | |||
| return(raw) | |||
| } else { | |||
There was a problem hiding this comment.
Couldn't some of the else if in this file be removed to instead just have if's?
if bla
return thing
if blop
return thing| @@ -163,14 +167,15 @@ ns_df <- function(name, token = NULL, size_limit = 1) { | |||
| } | |||
| meta <- name | |||
| net_ident <- c(meta[["collection_name"]], meta[["nets"]]) | |||
| names(net_ident) <- c("collection", "network") | |||
There was a problem hiding this comment.
could the names be added in the previous call?
net_ident <- c(
collection = meta[["collection_name"]],
network = meta[["nets"]]
)|
|
||
| on.exit(close(con_edge)) |
There was a problem hiding this comment.
would it make sense to take a dependency on withr and use withr::local_connection()? Or to define a helper since we'd call it at least four times?
|
Thank you! I will have a look at this soonish (I actually forgot about this PR...) |
Co-authored-by: Maëlle Salmon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #38