Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proof-of-concept: display saved duration in extension icon's badge #689

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

siadat
Copy link
Contributor

@siadat siadat commented Jul 20, 2020

As promised in #185 and requested in #643, here is a proof-of-concept for showing the total saved time on top of the extension icon. I wanted to see how it could work. My conclusion is that it adds too much complexity for a feature that is not of critical importance for the maintainer(s) of the project. So, I don't recommend it being merged. However, feel free to use it as the basis for your own experimentations. :)

Here's a screenshot of the badge indicating 9 minutes of saved time (in total, for all videos in all tabs since the extension was installed).

Screen Shot 2020-07-21 at 00 43 14

@igrigorik
Copy link
Owner

Thanks for prototyping this! Two thoughts..

There's been some suggestions around displaying time remaining, given the current speed, instead of time saved -- I think the former makes a lot more sense, as saved is just a vanity metric but remaining provides useful information. That said, if we're going to use the badge space, I think my preference is to reserve it for "current speed" -- shifting this display into the UI would fix a lot of potential problems for folks.

With above in mind, I think my suggestion is to park this but we can use it as reference in the future.

@igrigorik igrigorik added the Request For Comments Discussion (usually about design) label Sep 12, 2020
@siadat
Copy link
Contributor Author

siadat commented Sep 13, 2020

displaying time remaining, given the current speed

That sounds good, I would love that too. It would probably be simpler to implement as well (fewer states/information to handle).

Feel free to close/open this thread any time you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Request For Comments Discussion (usually about design)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants