Conversation
75a4f2a to
f83d20d
Compare
f83d20d to
6b9418b
Compare
293cf41 to
64fca17
Compare
64fca17 to
10aee8c
Compare
10aee8c to
59e5534
Compare
59e5534 to
fb59d37
Compare
fb59d37 to
4c4ec18
Compare
- Add ``bound_activity_up`` for furnace_elec_cement to timeseries_R12 in generic_furnace_boiler_techno_economic.xlsx - Remove in-code generation of same parameter data
- Generate cement CCS emission relation in .material.data_cement - Remove from .material.build
- Add csv copy of NTNU_LCA_coefficients.xlsx sheet environmentalImpacts - Adjust parser to use csv copy
Drop in favor of .util.common.load_package_data()
Drop historical countries from aluminum statistics
4c4ec18 to
a12464b
Compare
|
To make things slightly easier for reviewers:
|
|
Thanks, @khaeru for adding the links and instructions! |
|
Super helpful clean-ups! (The |
OK, understood. I usually start from the What's New and linked docs page as a starting-point to understand changes made in a PR, before going on to the code. But since this is the plan, I will just look at the code/data files directly (hopefully today), and expect they will be documented in another PR. |
|
I documented the changes of this PR in the docs here: I tried to cover most changes of this PR there. The follow-up documentation PR will rather tackle general documentation, as I realized that previous PRs did not comprehensively update/extend the material docs. |
This PR refactors the model building code of MESSAGEix-Materials and updates some parameter sets. It does not alter the model structure of MESSAGEix-Materials.
The following changes have been made:
.model.material.utilpycountryfunctions in favour of.model.util.pycountryyear_act&year_vtgdimension by entries where:.xlsxinput files to.csv.model.material.data_other_industryshare_constraints.pyEffective outcome:
How to review
developer (someone like the reviewer) will be able to understand what the code
does in the future.
PR checklist