fix: db setting error and duplicated keyword submission #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: decoupling routes (iiiyuki#30) * feat: decoupling routes * fix: remove unrelated files * change sh to zsh (iiiyuki#31) * feat: intro mybatis-plus (iiiyuki#32) * feat: mysql support and common fixes (iiiyuki#33) * feat: decoupling routes * fix: remove unrelated files * feat: error handler * feat: add vertx mysql support * feat: replace deprecated method * chore: renew authors * feat: description check of user upload added. (iiiyuki#34) --------- Co-authored-by: binary-austin <[email protected]> Co-authored-by: Jingyu Wang <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
binaryYuki
requested changes
Jan 31, 2025
Austin-152
requested changes
Jan 31, 2025
|
binaryYuki
approved these changes
Feb 3, 2025
Austin-152
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
Zephyrproject, primarily focusing on refactoring the database helper and improving the handling of entity managers. Key changes include the introduction of a singletondbHelperInstance, refactoring of entity manager handling, and updates to theMainVerticleclass.Refactoring and improvements:
src/main/java/Zephyr/MainVerticle.java: IntroduceddbHelperInstanceas a singleton and refactored thestartmethod to initialize the database and set up the HTTP server. Removed theinitializeServicesmethod and its associated code. [1] [2]src/main/java/Zephyr/dbHelper.java: Added methods to get and close the entity manager, and refactored the class to use a singleton pattern forEntityManagerFactory. [1] [2] [3] [4] [5]Entity manager handling:
src/main/java/Zephyr/JackRoutes.java: Replaced multiple instances ofdbHelper.getEntityManagerFactory().createEntityManager()withdbHelperInstance.getEntityManager(). Improved the handling of entity managers by ensuring they are closed properly. [1] [2] [3] [4] [5] [6] [7] [8]Testing updates:
src/test/java/Zephyr/TestJackRoutes.java: Corrected the expected HTTP status code in the test assertion for thehandleUploadmethod.Minor changes:
src/main/java/Zephyr/entities/AcceptedSequences.java: Removed an unnecessary blank line.