fix torque in ros2-dls hal - #4
Open
giulioturrisi wants to merge 9 commits into
Open
Conversation
Updated wording for clarity in ROS2-DLS HAL and ROS2-Official HAL sections.
…iper-ros2-dls into develop/fix_torque_ros2_dls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in the hal ros2-dls with torque. When a torque was sent, the kp and kd was set to 0 by default. This was not the intended behaviour, since if one want to have pure torque control, it should put kp and kd to zero by himself without hidden mechanism.
Furthermore, fixed the nomenclatore of DLS2 hal since it was misleading, everything is ROS2. Added a more concise message to higlight the usage of custom messages (ROS2-DLS Hal) or not (ROS2 Official)