fix: Target camera height/Y when using verticalfollow and zoom #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a part of fixes for ikemen-engine#1652.
github-actions
bot
added
the
PR: fix
|
So far so good. This fixes an issue I'd posted on Discord but not here yet. |
|
Looks good. Have you tried using targetScale instead of scale? I think it should be better. |
|
This is not need when #1760 is merged |
|
OK then, I will continue testing when #1760 is merged. Closing this then. |
github-actions
bot
added
PR: fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the biggest change/fix for #1652, however please do not close the issue yet - the scrolling still seems to be choppy to me and I am still testing it.
@Eiton - you may want to review as this changes the camera code again.