Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TopBoundBodyDist and BotBoundBodyDist triggers; fixes; refactoring #2324

Merged
merged 8 commits into from
Feb 13, 2025

Conversation

potsmugen
Copy link
Contributor

Features:

  • Added TopBoundBodyDist and BotBoundBodyDist triggers, which are similar to the non "body" versions but also account for the depth edge parameters

Fixes:

  • Fixed shadow fading range in stages with Z axis
  • Fixed explod and projectile shadow/reflection placement with Z axis
  • Fixed projectile shadows not working at all (possible regression)
  • Fixed superpause effect position and scale in Z axis
  • Fixed perspective drawing for different localcoord chars
  • Fixed physics S and C not affecting Z velocity
  • Fixed MakeDust crashing when using Z coordinates
  • Fixed Hitdef having a hardcoded depth of 4,4 instead of using the character's constant
  • Fixes Stage Shadow fade.range affected by z-axis #2308

Refactor:

  • Refactored MakeDust to be more like other bytecode state controllers and also work more like it does in Mugen
  • Adjusted TopBoundDist and BotBoundDist triggers to be more like their X axis counterparts

- These structs now use named declaration when referenced, making them easier to debug
- Fixed shadow fading range in stages with Z axis
- Fixed explod and projectile shadow/reflection placement with Z axis
- Fixed projectile shadows not working at all (possible regression)
- Fixed position and scale
- Moved common Z perspective calculations inside a function
- Fixed perspective for different localcoord chars
- Fixed explod scale updating in Z axis
- Fixed physics S and C not affecting Z velocity
- Previously setting an invalid spacing made MakeDust just not work. Now it will work but print an error message, like in Mugen
- Refactored MakeDust to be more like other bytecode state controllers
- Fixed MakeDust crashing when using Z coordinates
- Made MakeDust closer to how it works in Mugen (again)
- Spacing parameter does not care for the current state time but rather how long it's been since the last dust particle appeared
- Fixed Hitdef having a hardcoded depth of 4,4 instead of using the character's constant
- Added these triggers, which are similar to the non "body" versions but also account for the depth edge parameter
- Adjusted TopBoundDist and BotBoundDist triggers to be more like their X axis counterparts
@github-actions github-actions bot added the PR: feat This PR implements a new feature label Feb 13, 2025
@K4thos K4thos merged commit 370b014 into ikemen-engine:develop Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: feat This PR implements a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stage Shadow fade.range affected by z-axis
2 participants