Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bindtime of 1 immediately after PosSets not unbinding in time #2326

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

Jesuszilla
Copy link
Contributor

Please let me know if this causes any other regressions (but I haven't found any related with Anakaris).

This fixes the following situation:

[State 20000, Bind]
type = PosSet
trigger1 = 1
x = floor(root, Pos X + root, Vel X)
y = 0
ignorehitpause = 1
[State 20000, BindToRoot]
type = BindToRoot
trigger1 = 1
time = 1
pos = 0, -RootDist Y
ignorehitpause = 1

In MUGEN 1.0 and 1.1, this works and binds the helper to the root. In IKEMEN-Go, the bind was lasting longer than it needed to, leading to no effect from the PosSet.

@github-actions github-actions bot added the PR: fix This PR implements changes that don't belong to other categories label Feb 16, 2025
@K4thos K4thos merged commit afdf84e into ikemen-engine:develop Feb 16, 2025
2 checks passed
@NeatUnsou
Copy link
Contributor

A regression has occurred.
#194
I have confirmed that this fix has caused the problem to reoccur.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix This PR implements changes that don't belong to other categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants