fix: TargetBind and Snap default facing behavior now handled differently from BindToParent/root default facing #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly from BindToParent/BindToRoot default facing
github-actions
bot
added
the
PR: fix
|
This fixes the regression NeatUnsou pointed out in 3ha's Bishamon. |
|
I think the bug is not fixed Ikemen_GO.2025-02-20.00-25-39-950.mp4 |
|
I forgot that I made it easier for bugs to occur when I tested it before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default facing was broken in some instances for BindToParent/BindToRoot as discovered while working on Anakaris. Tested throw binds on Ultrarox_Clark, Warusaki3 Zangief, (WinMUGEN) and my WIP Anakaris (MUGEN 1.0 as of this writing), and helpers from Fusion's Zero (WinMUGEN) and my Anakaris (MUGEN 1.0).