Skip to content

fix(ecs): Use DateTime.UtcNow.Ticks instead of Stopwatch.GetTimestamp #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ecs): Use DateTime.UtcNow.Ticks instead of Stopwatch.GetTimestamp #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/SampSharp.Entities/Timers/TimerReference.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ internal TimerReference(TimerInfo info, object target, MethodInfo method)
}

/// <summary>Gets the time span until the next tick of this timer.</summary>
public TimeSpan NextTick => new(Info.NextTick - Stopwatch.GetTimestamp());
public TimeSpan NextTick => new(Info.NextTick - DateTime.UtcNow.Ticks);

internal TimerInfo Info { get; set; }

Expand Down
6 changes: 3 additions & 3 deletions src/SampSharp.Entities/Timers/TimerSystem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public TimerReference Start(Action<IServiceProvider, TimerReference> action, Tim
{
IsActive = true,
IntervalTicks = interval.Ticks,
NextTick = Stopwatch.GetTimestamp() + interval.Ticks
NextTick = DateTime.UtcNow.Ticks + interval.Ticks
};

var reference = new TimerReference(invoker, null, null);
Expand All @@ -79,7 +79,7 @@ public TimerReference Start(Action<IServiceProvider, TimerReference> action, Tim
[Event]
internal void OnGameModeInit()
{
_lastTick = Stopwatch.GetTimestamp();
_lastTick = DateTime.UtcNow.Ticks;

CreateTimersFromAssemblies(_lastTick);

Expand All @@ -92,7 +92,7 @@ public void Tick()
if (!_didInitialize || _timers.Count == 0)
return;

var timestamp = Stopwatch.GetTimestamp();
var timestamp = DateTime.UtcNow.Ticks;

// Don't user foreach for performance reasons
// ReSharper disable once ForCanBeConvertedToForeach
Expand Down
Loading