implement apt-transport-mirror handling by Artoria2e5 · Pull Request #168 · ilikenwf/apt-fast

Artoria2e5 · 2019-09-19T18:08:30Z

close #88

Lasall

This looks really good, thank you! I haven't applied and tried the patch, I think it doesn't work with a more complex mirror list (apt >= 1.6, see the apt-transport-mirror manpage) but imho a basic support is better than none.

close ilikenwf#88

The new mirrorlist variable is $MIRRORLIST. The cleanup_dllist function is now refactored to accept some arguments. The refactoring was intended for MIRRORLIST, but it then occurred to me that it was not meant for persistence anyway. So now it gets insta-deleted without need for a cleanup function. TMP_ variables previously used a pretty maintaience-heavy way to be assigned. I changed it to use the "nameref" magic in bash. Basically these variables are read/write proxies to some other variables.

Artoria2e5 · 2019-11-24T18:46:11Z

Alright. It does work on my end now. The grep regex is quite complicated now, but well that's what it takes...

Artoria2e5 · 2019-11-25T08:37:26Z

Got a seven-year-old bug fixed too.

The value was not updating because it was already evaluated at assign- time. To make it always update we need to make it a function call.

Lasall

I've looked over everything, one challenge I see is that this solution requires the MIRRORS variable to be set alongside the apt-transport-mirror setup. Otherwise only the first mirror from that list is picked.

I would suggest to split the shadowing thing up from the rest so we can merge the other chunk where only minimal changes are needed. I also really love the fixes and improvements you did along the way. Thank you!

Lasall · 2020-04-07T13:15:17Z

+  # I heard that people call this "variable shadowing."
+  declare -n this="$1" tmpthis="TMP_$1"
+  tmpthis="${this-${TMP_RANDOM}}"
+  sudo_exports+=("TMP_$1=$tmpthis")


needs to be without TMP_: sudo_exports+=("$1=$tmpthis")

I don't think so. There is a for i in "${shadowvars[@]}" part explicitly designed to unpack the TMP_ prefixed variables.

Just test to overwrite any of the variables via command line (e.g. _APTMGR). (Remove TMP_ to support cmd var precedence)

Lasall · 2020-04-07T15:54:51Z

+
+    local mirrors
+    mapfile -t mirrors < "$mirrorfile"
+    [ -f "MIRRORLIST" ] && rm -f "$MIRRORLIST"


missing $MIRRORLIST

The dollar sign was missing.

!!!

Suggested change

[ -f "MIRRORLIST" ] && rm -f "$MIRRORLIST"

[ -f "$MIRRORLIST" ] && rm -f "$MIRRORLIST"

Lasall · 2020-04-07T18:27:10Z

I tested the apt-transport-mirror with following configuration:

Sources list:

deb mirror+file:/etc/apt/mirrorlist unstable main non-free contrib
deb-src mirror+file:/etc/apt/mirrorlist unstable main non-free contrib
deb mirror+http://127.0.0.1/mirrorlist experimental main non-free contrib
deb-src mirror+http://localhost/mirrorlist experimental main non-free contrib

The local(host) mirrorlist(s):

http://deb.debian.org/debian/
http://ftp.de.debian.org/debian/

Lasall · 2020-04-07T18:29:46Z

I tested the shadowing with following test cases:

./apt-fast install "firefo*"  # should expand
_APTMGR="foo bar" ./apt-fast install firefox

haidarns · 2021-08-18T03:56:18Z

Hi, any update for this PR? or issue #88 ?

Lasall

README requires new entry to MIRRORLIST in config file.

Lasall

A few minor changes required. Mainly to fix the automatic sudo and cmd vars.

Lasall · 2021-08-25T23:16:55Z



+# Mirror listfile
+# This determines where temporary resolutions for the mirror:// url is stored.


url are stored

Lasall · 2021-08-25T23:36:11Z

-            ftp_proxy="$TMP_ftp_proxy" \
-            http_proxy="$TMP_http_proxy" \
-            https_proxy="$TMP_https_proxy" \
+  exec sudo "${sudo_exports[@]}"


Missing '\' at end of line

Lasall · 2021-08-25T23:43:41Z

+  # I heard that people call this "variable shadowing."
+  declare -n this="$1" tmpthis="TMP_$1"
+  tmpthis="${this-${TMP_RANDOM}}"
+  sudo_exports+=("TMP_$1=$tmpthis")


Just test to overwrite any of the variables via command line (e.g. _APTMGR). (Remove TMP_ to support cmd var precedence)

Artoria2e5 force-pushed the mirror-uri branch 2 times, most recently from 6350f41 to feeadc3 Compare September 19, 2019 18:16

Lasall requested changes Sep 23, 2019

View reviewed changes

Comment thread apt-fast Outdated

Comment thread apt-fast Outdated

Comment thread apt-fast

Artoria2e5 force-pushed the mirror-uri branch from 13e79b1 to dbb7cf5 Compare November 24, 2019 18:28

Artoria2e5 added 2 commits November 25, 2019 02:44

implement apt-transport-mirror handling

bc5c399

close ilikenwf#88

Artoria2e5 force-pushed the mirror-uri branch from c65f8b3 to 8efd201 Compare November 24, 2019 18:44

new contributor artoria2e5

83f5144

Artoria2e5 force-pushed the mirror-uri branch from 8efd201 to 83f5144 Compare November 24, 2019 18:45

Improve MIRRORS documentation

aa97f64

Artoria2e5 force-pushed the mirror-uri branch 2 times, most recently from 43233be to 8fe8ffc Compare November 25, 2019 08:44

fix apt_fast_prefix updating (make it a func)

11c8161

The value was not updating because it was already evaluated at assign- time. To make it always update we need to make it a function call.

Artoria2e5 force-pushed the mirror-uri branch from 8fe8ffc to 11c8161 Compare November 25, 2019 08:49

normalize mirror slashes

cb6eaea

Artoria2e5 requested a review from Lasall February 18, 2020 04:35

Lasall self-assigned this Apr 6, 2020

Lasall requested changes Apr 7, 2020

View reviewed changes

Lasall removed their assignment Mar 19, 2021

Artoria2e5 commented Aug 24, 2021

View reviewed changes

Comment thread apt-fast.conf Outdated

Artoria2e5 added 2 commits August 24, 2021 11:23

Apply suggestions from code review

9986a8e

Merge branch 'master' into mirror-uri

e7d00ee

Artoria2e5 commented Aug 24, 2021

View reviewed changes

Comment thread apt-fast Outdated

Update apt-fast

64ddc8c

Lasall reviewed Aug 25, 2021

View reviewed changes

Lasall requested changes Aug 25, 2021

View reviewed changes

Repository owner deleted a comment Nov 17, 2022

Repository owner deleted a comment Dec 8, 2022

Repository owner locked as spam and limited conversation to collaborators Dec 8, 2022

	[ -f "MIRRORLIST" ] && rm -f "$MIRRORLIST"
	[ -f "$MIRRORLIST" ] && rm -f "$MIRRORLIST"



		# Mirror listfile
		# This determines where temporary resolutions for the mirror:// url is stored.

Conversation

Artoria2e5 commented Sep 19, 2019

Uh oh!

Lasall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Artoria2e5 commented Nov 24, 2019

Uh oh!

Artoria2e5 commented Nov 25, 2019

Uh oh!

Lasall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lasall Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lasall commented Apr 7, 2020

Uh oh!

Lasall commented Apr 7, 2020

Uh oh!

haidarns commented Aug 18, 2021

Uh oh!

Uh oh!

Uh oh!

Lasall left a comment

Choose a reason for hiding this comment

Uh oh!

Lasall left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Lasall Aug 25, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Lasall Aug 25, 2021 •

edited

Loading

Lasall Aug 25, 2021 •

edited

Loading