Allow user to set the crate path of num_enum #77
Conversation
|
This closes #76 |
danielhenrymantilla
left a comment
danielhenrymantilla
left a comment
There was a problem hiding this comment.
Great, thanks for the quick PR! 🙏
I have some nits here and there, but otherwise LGTM ✅
|
@danielhenrymantilla hey, sorry for taking a while to get back to this. i think i have now addressed most of the points. |
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
LGTM, thanks! I have suggestions for a few very small tweaks, then let's merge!
num_enum/tests/try_build/compile_fail/multiple_crate_path.stderr
Outdated
Show resolved
Hide resolved
num_enum/tests/try_build/compile_fail/variants_with_fields.stderr
Outdated
Show resolved
Hide resolved
|
Can I help in any way to get this over the finish line and get this feature released? |
|
Anything I can do to speed this along? Would really help with a project I"m working on. Should I reopen a new PR? |
|
Yeah, if someone wanted to create a new PR for this addressing the final comments, I'd gladly review it - thank you! |
Add a `#[num_enum(crate = ..)]` attribute, which lets the user set where the num_enum crate is located.
|
it's been a while. i forgot about this 😅 |
|
Thank you so much! I've just released this in 0.7.5 |
5 participants
Add a
#[num_enum(crate = ..)]attribute, which lets the user set where the num_enum crate is located.