Skip to content

Add text on "Portions contributed by" in workflow #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add text on "Portions contributed by" in workflow #54

wants to merge 5 commits into from

Conversation

danmcd
Copy link
Member

@danmcd danmcd commented Jun 19, 2025

Fixes #53

@danmcd
Copy link
Member Author

danmcd commented Jun 19, 2025

I can be easily convinced to write more about what it takes to merit a "Portions contributed by" line.

nshalman
nshalman reviewed Jun 19, 2025
View reviewed changes
richlowe
richlowe approved these changes Jun 20, 2025
View reviewed changes
@danmcd
Copy link
Member Author

danmcd commented Jun 24, 2025

gmake worked just fine on this branch, FWIW.

@danmcd danmcd mentioned this pull request Jun 24, 2025
Merged
@danmcd
Copy link
Member Author

danmcd commented Jun 25, 2025

Appreciate the reviews, folks.

@rmustacc wants a crack at this, so I will not squash-and-merge until I get a sign-off from him.

@danmcd
Copy link
Member Author

danmcd commented Jun 25, 2025

Merged in a rewrite from @rmustacc . I might have missed deleting some things of mine.

@rmustacc
Copy link
Contributor

All I wanted to do was capture some prose about when you use this. Dunno if it's the clearest here or if separation makes sense or not.

danmcd
danmcd commented Jun 25, 2025
View reviewed changes
Copy link
Member Author

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept one thing from my original, citing new Multiple Authors section.

workflow Outdated
@@ -442,6 +442,8 @@ illumos has a standard commit format. That is:
```
<bug id> <synopsis>
<bug id 2> <synopsis 2>
<Portions Contributed n>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if this should be part of the merge or if I should clean this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshalman nshalman nshalman approved these changes

@richlowe richlowe richlowe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add text on "Portions contributed by" in workflow
4 participants
@danmcd @rmustacc @nshalman @richlowe