Fix show appends unit suffixes for Float values with units - #69
Merged
Conversation
DESIGN.md documents show 42.0<M> should produce '42.0 M', but the runtime printed '42.0'. TypeEnv.show_unit_strings was never populated or read — the unit system existed in the type checker and codegen but the runtime had no way to know a Float's unit string. Fix: codegen registers unit strings at init via knot_register_show_unit (populated from the unit inference results). The runtime's show function appends the unit suffix when a Float has a registered unit. stripUnit remains the escape hatch for bare-number output. 3 new end-to-end tests in regress_show_units.rs: DESIGN examples, computed units (100.0<M> / 4.0<S> -> '25.0 M/S'), polymorphic case. 2 new runtime tests. Full workspace: 1655 passed, 0 failed.
ilyakooo0
force-pushed
the
push-mylqzqrkurvu
branch
from
July 12, 2026 00:40
182c30f to
4f901d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DESIGN.md documents
show 42.0<M>should produce"42.0 M", but the runtime printed"42.0".TypeEnv.show_unit_stringswas never populated or read — the unit system existed in the type checker and codegen but the runtime had no way to know a Float's unit string.Fix
knot_register_show_unit(populated from unit inference results)showfunction appends the unit suffix when a Float has a registered unitstripUnitremains the escape hatch for bare-number outputTests
regress_show_units.rs: DESIGN examples, computed units (100.0<M> / 4.0<S>→"25.0 M/S"), polymorphic caseVerification