Fix all 82 bugs from BUGS.md audit - #85
Merged
Merged
Conversation
The try_infer_fetch function already handles ast::ExprKind::Constructor(_) by returning None for record_arg (infer.rs:5817), skipping payload unification for bare nullary route constructors. The response type is resolved from route metadata regardless. Verified by cargo test -p knot-compiler (all tests pass).
Both infer and codegen now use last-wins in source declaration order for constructor name resolution. infer.rs:7651-7663 always inserts fetch_response_headers (even when empty) to prevent stale header chimera. codegen.rs:1919-1928 populates fetch_route_entries with last-wins insert, and compile_fetch (codegen.rs:7082) looks up by ctor_name from this map. Verified by cargo test -p knot-compiler (all tests pass).
Prelude spans are shifted by PRELUDE_SPAN_OFFSET (1 << 40) in base.rs:201-203, far above any plausible user file size and above desugar::SYNTH_SPAN_BASE (1 << 31), so prelude monad_info keys can never collide with user-file or synthesized spans. Verified by cargo test -p knot-compiler (all tests pass).
The race parent (lib.rs:8464-8481) polls with RACE_CANCEL_POLL (50ms timeout) and checks cancel_requested() between waits. When outer cancellation fires, it cancels both inner workers (cancel_a.cancel(), cancel_b.cancel()) and unwinds with Cancelled — exactly like other cancellation checkpoints. Verified by cargo test -p knot-runtime (all 161 tests pass).
A HandlerDropGuard (lib.rs:17241-17246) wraps the deep-cloned handler tree across knot_db_open, which can panic via .expect. The guard's Drop calls deep_drop_value, preventing the leak. Once db_open succeeds, the guard is forgotten so manual drops retain sole ownership. Mirrors IoDropGuard in knot_fork_io and the race worker. Verified by cargo test -p knot-runtime.
…monotone aggregates (B29-B31)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Went through every bug in
BUGS.md(82 total, 16 previously marked fixed) and verified each one against the current codebase. All 82 bugs are now marked as[x]— 0 remaining.Bugs requiring actual code fixes (4):
codegen.rs)migrate … usingviaknot_source_migrate_preview(codegen.rs)stratify.rs)value_contains_nonfinite_floatmade iterative over work stack to avoid stack overflow on deep constructor spines (lib.rs)Bugs already fixed in code (78):
The majority of bugs had been fixed in prior commits (#59–#74) but were never marked as
[x]inBUGS.md. Each was verified against the current codebase and marked accordingly.Verification
cargo build✅cargo test— 1,685 tests passed, 0 failed ✅