Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87 add blurring tutorial #94

Merged
merged 12 commits into from
Feb 5, 2024
Merged

87 add blurring tutorial #94

merged 12 commits into from
Feb 5, 2024

Conversation

EscapedGibbon
Copy link
Contributor

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Jan 22, 2024 that may be closed by this pull request
Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4818f87
Status: ✅  Deploy successful!
Preview URL: https://fba3d7c8.image-js-docs.pages.dev
Branch Preview URL: https://87-add-blurring-tutorial.image-js-docs.pages.dev

View logs

@stropitek
Copy link
Contributor

However, this also means that every pixel has the same weight to the algorithm regardless of its position

This is not an explanation of why mean blur is potentially inferior to other types of blur. It's just an explanation about how the algorithm works. I suppose gaussian blur has nicer mathematical properties, but I would not really be able to expand much on that. Either drop this or try to do some research to have a valid explanation of why gaussian blur is a better choice in some circumstances.

@stropitek
Copy link
Contributor

CleanShot 2024-01-24 at 16 14 00

Not really understand what you mean by "If box blur looks like that ... gaussian blur might look like that". You explained that box blur is any blur that uses a convolution matrix no?

@stropitek
Copy link
Contributor

The values of the table will probably be floating numbers rather than integers

In what circumstances?

@stropitek
Copy link
Contributor

stropitek commented Jan 24, 2024

CleanShot 2024-01-24 at 16 16 33

Would it be worse with mean blur?

@stropitek
Copy link
Contributor

If an image is of decent quality and you want .

There is an unfinished phrase

@stropitek
Copy link
Contributor

Some parts look good, and I like the gif on convolution

@EscapedGibbon EscapedGibbon marked this pull request as ready for review January 29, 2024 12:55
@stropitek
Copy link
Contributor

Gaussian blur applies gaussian distribution formula to create a matrix which weighted average for convolution which means that it takes into account the position of the pixel as well.

The sentence is not very clear to me (at least there systax errors).

Also the point you do about performance difference between box blur and gaussian at the beginning of the article does not seem obvious to me. You are saying that calculating the kernel values makes it slower, but that has to be done only once so I don't think that affects performance.

@stropitek stropitek merged commit dd5973a into main Feb 5, 2024
7 checks passed
@stropitek stropitek deleted the 87-add-blurring-tutorial branch February 5, 2024 09:41
EscapedGibbon added a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add blurring tutorial
2 participants