This repository was archived by the owner on Jul 26, 2025. It is now read-only.
fix: resize nearest #454
Merged
fix: resize nearest #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
targos
suggested changes
May 2, 2024
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
It can ref https://github.com/image-js/image-js-typescript/issues/452, but it doesn't close it (only nearest-neighbor is fixed).
chirurgical fix, rework of #453 Refs: https://github.com/image-js/image-js-typescript/issues/452
tpoisseau
force-pushed
the
452-resize-method-doesnt-work-properly-try-2
branch
from
6e8748a to
1944341
Compare
Contributor
Author
|
Ok for refs instead closes. |
targos
reviewed
May 2, 2024
targos
approved these changes
May 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: image-js/image-js#654
chirurgical fix, rework of #453
previous PR had lot of issues due to fix for bilinear interpolation breaking lot of tests for general worse results (only clear better results was for the opencv bilinear test).
better / worse are personal appreciation.
This PR fix resize with nearest interpolation by using transform matrix without change
interpolateNearestfunction and adding small translation to compensate.Changing interpolation function would break some tests but not for the best. I continue to think more work need to be done on this topic.
It's a lot of work to plan for really small, nearly impossible to see with the naked eye and lot of decision and estimation to do to actualize breaking tests or not.