-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update free_functions.rs #2408
Update free_functions.rs #2408
Conversation
Support guessing AVIF image generated by this library (with native avif)
The array size needs to be updated, but otherwise looks good to me |
You are right my bad I will update it |
I ran the test locally and the failing test do not seem related to my commit but I could be wrong? |
Thanks! |
These bytes before Instead of collecting implementation-specific lengths, can the length be allowed to be any bytes? The two most significant bytes could be required to be 0, since the chunk is unlikely to ever exceed 64K. |
I wondered it myself but could not see how to do it with the current implementation |
A simple solution could be to add a start offset to the table of magic strings, and skip 4 bytes in AVIFs case. |
If we included a mask of bytes to ignore, we could also have an actual fix for #660 |
Support guessing AVIF image generated by this library (with native avif)
Exemple of image generated by this library with the magic bytes not yet recognized:
image.zip