Draft
Conversation
This adds tests converting from ImagePlus to: - ImageDisplay - Dataset - ImgPlus (not yet functional, therefore disabled) - Img In addition, we test that the current plane position of an ImagePlus and its converted ImageDisplay equivalent stay in sync. This currently works ImageDisplay -> ImagePlus but not ImagePlus -> ImageDisplay.
This commit adds a delegate converter from ImagePlus to ImgPlus via Dataset, and enables the corresponding test that was added in the previous commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds tests converting from
ImagePlusto:ImageDisplayDatasetImgPlus(not yet functional, therefore disabled)converter addedImgIn addition, we test that the current plane position of an
ImagePlusand its convertedImageDisplayequivalent stay in sync. This currently worksImageDisplay -> ImagePlusbut notImagePlus -> ImageDisplay.(Note: Some of the tests are redundant because
ImagePlusConversionTesthas them already. The new tests added here are work in progress to improve the test coverage and move towards fixing the issues summarized in #231.)