Conversation
Because the app folder is signed as a whole, if any file changes the signing will have to change. This also means that if any file in Fiji.app is updated, we do not want to leave a .old version in the app folder as that will invalidate the signing. Instead, if we now detect any file in the .app folder is updated, we archive the complete state of the app folder to a single .old.app, and flag all files in the .app folder for installation/update.
Member
Author
|
@ctrueden this works for me and I'm happy with it. Can you test this on your system to make sure it behaves in a way you think is reasonable too? The way I tested it was with:
If you update the modified file you should end up with a Let me know if that doesn't work for you or if you think anything should work differently here |
ctrueden
approved these changes
May 8, 2025
Member
ctrueden
left a comment
ctrueden
left a comment
There was a problem hiding this comment.
Looks great! The directory deleting and copying code is kinda clunky, but if it works, I'm not worried about it. Can always be improved later.
| return file.renameTo(backup); | ||
| } | ||
|
|
||
| private static void deleteDirectory(Path directory) throws IOException { |
Member
There was a problem hiding this comment.
Is there a reason you didn't use org.scijava.util.FileUtils.deleteRecursively?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the app folder is signed as a whole, if any file changes the signing will have to change. This also means that if any file in Fiji.app is updated, we do not want to leave a .old version in the app folder as that will invalidate the signing.
Instead, if we now detect any file in the .app folder is updated, we archive the complete state of the app folder to a single .old.app, and flag all files in the .app folder for installation/update.