Fixed missing namespaces in some Helper classes #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
I fixed issue #57 by adding
namespace Imagekit.HelpertoUrl.cs,Transformation.csandTransformationTypes.cs.I also added any necessary
usingstatements where needed and followed your pattern of putting using statements inside the namespace withglobal::where needed.Url.cs,Transformation.csandTransformationTypes.cswere also slightly reformatted automatically by my IDE, but it doesn't seem like there were any meaningful changes, mostly just indentation to account for the added namespace.Testing
I built the project to make sure it compiles correctly and ran all the unit tests. All unit tests passed on the dotnet versions I had installed.
Note that I didn't have all the dotnet versions that the unit tests use installed, but given the minimal changes I am pretty confident the tests would pass on those versions of dotnet too.