-
Notifications
You must be signed in to change notification settings - Fork 35
extract full exif and xml metadata from jxl images with metadata compressed #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extract full exif and xml metadata from jxl images with metadata compressed #14
Conversation
09ca5bc to
5daff74
Compare
|
Can you update the description to describe how you have tested this and what impact it has to the final size of the base image? |
For image size impact:
Prune all dangling images and delete:
Git swich to my fixBuild dev and prod images from scratch:Prod image with the fix contains 1 additional MB, and dev image with the fix contains 570 additional MB. Testing approachI provided already in the issue URL from this PR description how to create a JXL image from an existing JPEG and also how to test without the fix and with the fix but I will try to make it a bit simpler, if it doesn't look like so. Testing without the fixAlternative 1 - Test against immich-app/base-server-dev or immich-app/base-server-prod
Alternative 2 - Test against immich-app/immich-server, the version 1.87.0 or later.Do steps 1 to 5, inclusive, and step 2 exclusive from Alternative 1.
The output is exactly like in Alternative 1, step 7. Alternative 3 - Test against Immich browser app, the version 1.87.0 or later.You need to have the JXL file (check Alternative 1). Testing with the fixAlternative 4 - Test against immich-app/base-server-dev or immich-app/base-server-prod that contains the fix. See at the beginning how I built them in order to see the impact of the fix on the size of the image.
Steps 3 to 6, inclusive should be the same.
You should be able to see the full EXIF data of your original JPEG file Alternative 5 - Test against immich-app/immich-server with the fix, similar with Alternative 2.Alternative 6 - Test against Immich browser app, using images with the fix. You have to build yourself all 3 images (immich-server, immich-microservices and immich-machine-learning). For this you have to modify server/Dockerfile from immich repository:
Buuld images, deploy, upload the JXL file and check the JXL metadata by pointing to the image and then info. It should have the right datetimes and also GPS. The image should also appear on the map. |
|
@amitrea kudos for the most comprehensive PR writeup we've ever seen 😄 |
|
I appreciate all your feedbacks. |
Add support to extract full EXIF and XML metadata from JPEG XL(JXL) files. For a detailed description of the current issue please see issue.
Currently, those that have all or the majority of the images in JPEG XL format will not be able to see/edit any EXIF/XML metadata (GPS data, original datetimes), searching images by metadata and geo tagging information.