WIP: Split crates requiring nightly Rust into separate unstable workspace

[joshtriplett]

No description provided.

[joshtriplett]

Marking as WIP, because it'll need some CI debugging to make sure tests don't fail.

[kkysen]

Also I merged #1225 so you can rebase now.

[joshtriplett]

Currently attempting a full implementation of #1220. Still WIP; will work on ensuring CI passes.

[joshtriplett]

Side note: analysis/tests/minimal/reference_pdg.bc was checked in despite being .gitignored. It doesn't look like that test is using "compare" mode, so I don't think that file is being used, only written to. Nonetheless, I moved it across to unstable/analysis/tests/minimal/reference_pdg.bc. If there's any potential cleanup there, it can happen separately from this PR.

[joshtriplett]

@kkysen For some reason, the Azure pipeline doesn't seem to be kicking off for pushes anymore, and I'm not sure why. I think I've fixed most of the issues at this point, but I can't test that until the Azure pipeline runs again.

EDIT: Seems to be working again.

[joshtriplett]

@kkysen I just realized that the Docker images probably don't get rebuilt as a result of this pipeline; I updated the scripts that build Docker images, and then the failure is happening because the CI runs using the old Docker images.

I think this may be easiest to fix by going ahead and switching away from Azure pipelines. I'll work towards that.

[kkysen]

Side note: analysis/tests/minimal/reference_pdg.bc was checked in despite being .gitignored. It doesn't look like that test is using "compare" mode, so I don't think that file is being used, only written to. Nonetheless, I moved it across to unstable/analysis/tests/minimal/reference_pdg.bc. If there's any potential cleanup there, it can happen separately from this PR.

It's used in a test here:

c2rust/c2rust-analyze/tests/analyze.rs

Line 74 in 4b7691e

let pdg_path: PathBuf = "../analysis/tests/minimal/reference_pdg.bc".into();

As long as you keep the relative paths the same, it should still work fine. We in general gitignored *.bc files but added this one manually for this one test.

[kkysen]

@kkysen I just realized that the Docker images probably don't get rebuilt as a result of this pipeline; I updated the scripts that build Docker images, and then the failure is happening because the CI runs using the old Docker images.

I think this may be easiest to fix by going ahead and switching away from Azure pipelines. I'll work towards that.

Oh yes, that's always been one of the very annoying pain points with Azure pipelines. We have to update the docker images separately, and so we can't test multiple in CI at the same time either. One of the many reasons I've always wanted to move away from Azure pipelines. I agree it's probably easier to just move to GitHub Actions in one go and things will work better there. Thanks again for helping with all of this!