Skip to content

Minor refactor for project validation on create and update #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
clkao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Minor refactor for project validation on create and update #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions lib/routes/api/v2/projects/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,16 @@ var canCreateProject = function(req, res, next){

};

var validateProject = function(project) {
if (!project.title){
return { error: "title_required" };
}

if (!project.description){
return { error: "description_required" };
}
}

var createProject = function(req, res, next){

if(req.body.link && req.body.link.indexOf('http') != 0) {
Expand All @@ -103,12 +113,9 @@ var createProject = function(req, res, next){
, domain: req.body.domain
});

if (!project.title){
return res.json(500, { error: "title_required" });
}

if (!project.description){
return res.json(500, { error: "description_required" });
var err = validateProject(project);
if (err) {
return res.json(500, err);
}

project.save(function(err, project){
Expand Down Expand Up @@ -180,12 +187,9 @@ var updateProject = function(req, res, next) {

//add trim

if (!project.title){
return res.json(500, { error: "title_required" });
}

if (!project.description){
return res.json(500, { error: "description_required" });
var err = validateProject(project);
if (err) {
return res.json(500, err);
}

project.save(function(err, project){
Expand Down