-
Notifications
You must be signed in to change notification settings - Fork 184
[FEATURE] Add morestep fieldset validation #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: typo3-v12
Are you sure you want to change the base?
[FEATURE] Add morestep fieldset validation #1090
Conversation
* to validate those fields in multistepform for example
* if the data-powermail-morestep-validate attribute is set to "true" on morestep button (new option) * we validate the visible fields and scroll to the first error in error case
* without it's problamtic if the fieldsets differ in height * if true, the user has to scroll manually to input the new fieldset
* scroll on navigation click, not on btn-group link above
The release of feature/visible-field-validation looks good. But unfortunately the form.min.js does not contain the Javascript adjustments. |
The |
I updated the PR to the latest commit ( |
Thanks for your contribution and continously updating the PR . I am really sorry for the delay. :-( We implemented the morestep validation for v13 while EAP. We basically do not implement new features in v12. If you really need it, we would do it as a payed service. I am really sorry for that. As you see in the past months the development for powermail got much more active, since in2code sponsors several hours per week to work on powermail. If you have any questions, please do not hesitate to contact me via TYPO3s slack or comment here. Best regards |
Hi @mschwemer , we thought this feature was implemented in v13, but found out that it was not. So our patch continues relevant even in v13. Is there any reason not to implement this change? Its very frustrating for the users of multi-step forms to only get notified about validation errors after going through all steps and hitting "submit", instead of being able to correct the mistakes right on the page where it happens. |
I reopen this issue / PR, so it does not get lost. Need to recheck it. Sorry for that |
We need the option to validate the current (visible) fieldset on multistep forms.
The validation is done clientsided in JavaScript on page switch and scrolls to the first visible error if exist.
To simplify the usage, the setting validation.morestep.fieldset was added.
As a nice to have improvement, a simple scroll into view for multistep forms on page switch was added, to avoid manual user scrolling if the height of the fieldsets differ.