Skip to content

aria-required not necessary when native required present #1238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: typo3-v12
Choose a base branch
from
Open

aria-required not necessary when native required present #1238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Classes/ViewHelpers/Validation/AbstractValidationViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ protected function addMandatoryAttributes(array $additionalAttributes, ?Field $f
$additionalAttributes['data-powermail-required'] = 'true';
}
}
$additionalAttributes['aria-required'] = 'true';

if ($this->isClientValidationEnabled()) {
$additionalAttributes['data-powermail-required-message'] =
Expand Down
4 changes: 0 additions & 4 deletions Classes/ViewHelpers/Validation/ValidationDataAttributeViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,17 +96,14 @@ protected function addMandatoryAttributesForMultipleFields(
if ($field->isMandatory()) {
if ($this->isNativeValidationEnabled()) {
$additionalAttributes['required'] = 'required';
$additionalAttributes['aria-required'] = 'true';

// remove required attribute if more checkboxes than 1
if ($field->getType() === 'check' && $iteration['total'] > 1) {
unset($additionalAttributes['required']);
unset($additionalAttributes['aria-required']);
}
} else {
if ($this->isClientValidationEnabled()) {
$additionalAttributes['data-powermail-required'] = 'true';
$additionalAttributes['aria-required'] = 'true';
}
}
if ($this->isClientValidationEnabled()) {
Expand All @@ -117,7 +114,6 @@ protected function addMandatoryAttributesForMultipleFields(
LocalizationUtility::translate('validationerror_mandatory_multi');
if ($field->getType() === 'check') {
$additionalAttributes['data-powermail-required'] = 'true';
$additionalAttributes['aria-required'] = 'true';
}
}
}
Expand Down
1 change: 0 additions & 1 deletion Tests/Unit/ViewHelpers/Validation/DatepickerDataAttributeViewHelperTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ public static function renderReturnsArrayDataProvider(): array
'data-datepicker-format' => 'YYYY-MM-DD HH:mm',
'data-date-value' => 'anyvalue',
'required' => 'required',
'aria-required' => 'true',
'data-powermail-required-message' => 'validationerror_mandatory',
],
],
Expand Down