feat: observations/place_count endpoint#543
Open
kfc35 wants to merge 6 commits intoinaturalist:mainfrom
Open
Conversation
kfc35
changed the title
kfc35
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A continuation of #511 to address kueda’s comments, adds a new parameter called
count_place_idto filter in the desired places. I found a nifty “include” attribute to do this. I also added a customorder_byso you can only order byidorcount.I wrote a couple more tests to test out the attribute for the endpoint (which, if my earlier pull concerning new test methods is merged first #542 and you want to wait a little bit, I can use those methods instead).
Closes #56
Builds upon & Closes #511
If a v2 endpoint is desired, please let me know; I can add one.