Update react-native-sensitive-info to v6 - #3927
Merged
jtklein merged 10 commits intoAug 17, 2026
Merged
Conversation
If they contradict we probably lost the access token. For example, in this upgrade PR we loose the previous auth tokens state and are unable to authenticate to the API as the current user. So, in order to not loose all saved observations, and other realm state, we route to the login screen to login again and obtain new auth credentials.
jtklein
marked this pull request as ready for review
August 11, 2026 16:27
websoty
reviewed
Aug 11, 2026
| const { i18n } = useTranslation( ); | ||
|
|
||
| useEffect( ( ) => { | ||
| const id0 = deferTask( "checkLoggedInStatuses", async () => { |
There was a problem hiding this comment.
Could this miss the re-login flow if navigationRef isn't ready when this deferred task runs? Since this is a one-time check, it looks like wouldn't retry once navigation becomes ready
maybe I'm wrong ...
sepeterson
approved these changes
Aug 13, 2026
sepeterson
left a comment
sepeterson
left a comment
Contributor
There was a problem hiding this comment.
Code looks good.
I did find that the upgrade path on android seems to require sign-in again. Probably good to get this out now. iOS went fine
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes MOB-1638 (also closes MOB-1160)
Summary
Test plan