Skip to content

fix(desktop): skip restart confirmation when all work resumes - #1077

Open
incognitojam wants to merge 3 commits into
mainfrom
styal/update-local-restart-confirmation
Open

incognitojam wants to merge 3 commits into
mainfrom
styal/update-local-restart-confirmation

Conversation

@incognitojam

@incognitojam incognitojam commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

Restarting a desktop app still asked for confirmation when every active thread would resume. Allow that restart to proceed after every owned backend has been checked. Quit continues to ask about active work because it will wait until the next launch to resume.

Running or unknown terminal commands, waiting requests, non-continuable threads, provider installations, shared devices, and failed checks still require confirmation. This layer changes only the local desktop guard.

Exercised the real guard with resumable-only work, disabled continuation, backend replacement, Quit cancellation, each interruption type, and unavailable inspections. Safe restarts bypassed presentation; blockers and Quit retained the dialog. An OS installer relaunch was not performed.

This is the bottom of the stack and can land independently. The standalone skipped-summary fix is #1076.


Written by an agent (Codex, gpt-6.1-sol).

@incognitojam
incognitojam added this pull request to stack #1080 October 25, 2026 21:50
@incognitojam incognitojam changed the title styal/update local restart confirmation fix(desktop): skip restart confirmation when all work resumes Oct 25, 2026
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Upstream divergence

Both sides are compared with upstream at the in-order tip 3982f20ce4. Excludes .repos/ and pnpm-lock.yaml.

Measure Base This PR Change
Upstream files the fork changes 1,689 1,689 0
Lines changed in them 91,770 91,773 +3
Upstream files the fork removes 49 49 0
Fork-only files 661 661 0
Fork-only lines 118,813 118,899 +86
Upstream files whose difference changes (1)
File Change Now differs by
docs/user/updating.md +3 141 lines

@incognitojam
incognitojam force-pushed the styal/update-local-restart-confirmation branch from 58b463c to 2fc2dc0 Compare October 25, 2026 21:52
@incognitojam
incognitojam marked this pull request as ready for review October 25, 2026 21:55
@github-actions

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ℹ️ The exact PR base did not have a successful artifact. Baseline uses the latest successful main measurement shown below.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 5.0 KiB 4.9 KiB −30 B (−0.6%) 6.8 KiB ✅
Codex Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Codex Live turn WebSocket wire 1.2 KiB 1.2 KiB −30 B (−2.5%) 2.0 KiB ✅
Codex Live turn WebSocket decoded 20.9 KiB 20.8 KiB −41 B (−0.2%) 29.3 KiB ✅
Codex Live turn messages 2 1 −1 (−50.0%) 8 ✅
Claude Total thread wire 5.0 KiB 5.0 KiB +7 B (+0.1%) 6.8 KiB ✅
Claude Thread snapshot wire 3.8 KiB 3.8 KiB 0 B (0.0%) 4.9 KiB ✅
Claude Live turn WebSocket wire 1.2 KiB 1.2 KiB +7 B (+0.6%) 2.0 KiB ✅
Claude Live turn WebSocket decoded 21.2 KiB 21.2 KiB 0 B (0.0%) 29.3 KiB ✅
Claude Live turn messages 2 2 0 (0.0%) 8 ✅

Baseline: 8fa205a · PR result: 2fc2dc0 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 108.5 KiB
  • Claude decoded thread snapshot: 108.8 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant