Repository navigation
fix(diffs): sort *.gen.* files and drizzle-kit metadata as generated - #933
Merged
Merged
Conversation
Upstream divergenceBoth sides are compared with upstream at the in-order tip
Upstream files that start to differ (1)
Upstream files whose difference changes (1)
|
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This was referenced Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drizzle projects' pull requests and diffs listed
drizzle/meta/_journal.jsonand thedrizzle/meta/NNNN_snapshot.jsonfiles as source, so hundreds of lines of drizzle-kit bookkeeping sat above the code a reviewer needs to read and started expanded. TanStack Router'srouteTree.gen.tsand other*.gen.*output had the same problem.diffFileTiernow classifies two more name patterns as generated:*.gen.*, alongside the existing*.generated.*._journal.jsonandNNNN_snapshot.json, only when they sit directly in ameta/directory.The SQL migrations drizzle-kit writes stay in the source group, because they are what runs against the database. Repositories can still mark other generated paths through
linguist-generatedin.gitattributes. The classification is shared, so the change covers turn, working-tree, branch and pull request diffs on web and desktop, the changed-files card, and mobile review.Validation
diffFileTiercases: drizzle journal and snapshot files androuteTree.gen.tsare generated;drizzle/0004_small_mentor.sql,src/meta/settings.jsonandsrc/codegen.tsstay source.vp test run packages/shared/src/diffFileOrder.test.tspasses (25 tests).orderUnloadedDiffFileson file names from a real drizzle pull request. The SQL migrations,README.mdandsrc/files come first, thenhome.test.ts, then the drizzle meta files,pnpm-lock.yamlandrouteTree.gen.tswith the generated tag.Written by an agent (Claude Code, claude-opus-5-5).