Repository navigation
feat(web): setup ends with a Workflow step for automatic settling - #935
Open
incognitojam wants to merge 3 commits into
Open
incognitojam wants to merge 3 commits into
incognitojam wants to merge 3 commits into
Conversation
Setup now ends with a Workflow step that explains settling and offers the merge and inactivity rules before the user reaches the sidebar. Choices apply to every selected computer that supports automatic settlement, keeping each computer's own inactivity threshold. Finishing records the two choices as a setup-thread-settlement usage event.
Upstream divergenceBoth sides are compared with upstream at the in-order tip
Upstream files whose difference changes (2)
|
Moves the fork-only step out of the upstream welcome wizard so upstream intake has a smaller diff to reconcile.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic settling surprises people who don't work the way it assumes: threads move into the Settled shelf when their PR merges or after three days idle, and nothing in setup says so. Setup is the one place every new user passes through, so it now explains settling and lets people keep or turn off those rules before they reach the sidebar.
Setup gains a final Workflow step after Projects (and Preferences, when that appears). It has a short explanation, a static picture of the sidebar with a settled thread, and two switches: settle when the pull request merges, and settle after N days without activity. The step is named for workflow defaults in general so more of them can join it later. Which ones join will be decided from usage data and user feedback.
/welcomeshows the saved choice.setup-thread-settlementusage event with only the two choices. This bumps the fork client usage vocabulary to version 3.Validation
In a dev server with isolated state, through
/welcomein the Browser panel:settings.jsonheldsidebarAutoSettleOnMerge: false./welcome: the step opened with the merge switch off. Turned it back on and inactivity off, chose Finish:sidebarAutoSettleAfterDays: null, and Settings → General showed merge on and inactivity off.settlement.logic.test.ts), the usage event allowlist (ClientFeatureUsage.test.ts), and the existing onboarding and import tests; web typecheck and the ledger check pass.Not verified: delivery of the usage event to PostHog (dev telemetry has no collector; the server test covers what is recorded), and the multi-computer path, which shares the per-computer patch logic covered by tests.
Written by an agent (Claude Code, claude-opus-5-5).