Support graphql-ruby 2.x #32
Merged
+42
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 7bf51ae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 100.0%. View more on Code Climate. |
tomoasleep
force-pushed
the
support-graphql-2
branch
from
5c82f65 to
7bf51ae
Compare
tomoasleep
force-pushed
the
support-graphql-2
branch
3 times, most recently
from
d9bd6e2 to
6298325
Compare
tomoasleep
force-pushed
the
support-graphql-2
branch
from
6298325 to
6608283
Compare
tomoasleep
force-pushed
the
support-graphql-2
branch
from
6608283 to
b7e9ebc
Compare
tomoasleep
force-pushed
the
support-graphql-2
branch
from
7ee5d53 to
8f64924
Compare
tomoasleep
commented
Dec 18, 2024
Comment on lines
+1
to
+4
| # Merge default configurations on Exclude option | ||
| inherit_mode: | ||
| merge: | ||
| - Exclude |
Member
Author
There was a problem hiding this comment.
RuboCop has default Exclude configurations (link).
With this option, the default configurations and the configurations in this file are merged.
Member
Author
There was a problem hiding this comment.
Without this option, RuboCop on CI may fail due to lack of default Exclude configurations. (RuboCop reads configuration files and ruby files in vendor/bundle/**/*)
Ref: rubocop/rubocop#9832
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds graphql-ruby 2.x to available versions.
Also, this PR prepares multiple gemfiles to test with graphql-ruby 1.x and 2.x.
These gemfiles are generated by appraisal.