Add dependency concurrent-ruby

[atm-snag2]

What

Close #39

• add dev dependency limitation for concurrent-ruby

Why

• It requries concurrent-ruby less than 1.3.5 as it depenends on activerecord 6.0 in development environment.

[gemini-code-assist]

Hello @atm-snag2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR, authored by atm-snag2, aims to address issue #39 by adding the concurrent-ruby gem as a development dependency in the graphql-kaminari_connection.gemspec file. Specifically, it adds a version constraint to this dependency, limiting it to versions less than 1.3.5. This change is focused solely on the development environment setup for the gem.

Highlights

• Dependency Management: Adds concurrent-ruby as a development dependency.
• Version Constraint: Specifies a version constraint (< 1.3.5) for the concurrent-ruby development dependency.
• Issue Resolution: Closes issue #39, suggesting this change is related to a problem or requirement identified in that issue.

Changelog

• graphql-kaminari_connection.gemspec
  • Added concurrent-ruby as a development dependency with a version constraint < 1.3.5.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

A gem needs its friends,
Listed in the spec file's ends,
Versions constrained tight,
Keep the dev build right,
No conflicts, the code transcends.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses issue #39 by adding a version constraint for the concurrent-ruby gem in the development dependencies. This is a necessary change to prevent conflicts with older versions of graphql-ruby that are also used in the development environment.

Summary of Findings

• Development dependency constraint for concurrent-ruby: Added a version constraint < 1.3.5 for the concurrent-ruby development dependency to resolve compatibility issues with older graphql-ruby versions used in the test environment (addresses issue #39).

Merge Readiness

The change correctly addresses the compatibility issue with concurrent-ruby and graphql-ruby in the development environment. The code change is minimal and directly resolves the problem described in issue #39. Based on this review, the pull request appears ready to be merged. Please note that I am unable to directly approve the pull request; other reviewers should review and approve this code before merging.

[gemini-code-assist]

Adding the concurrent-ruby gem as a development dependency with a version constraint < 1.3.5 is a good approach to mitigate the compatibility issue with graphql-ruby versions prior to 2.2.0, as described in issue #39. This ensures that the development and testing environment remains stable when using the specified graphql dependency range (>= 1.9, < 3.0.0.a).

[tomoasleep]

Is there a reason why you specify version constraint (< 1.3.5) ?

[atm-snag2]

I think It requries concurrent-ruby less than 1.3.5 as it depenends on activerecord 6.0 in development environment.

Refs

• Rails 7.0.8 fails to create an app with most recent concurrent-ruby version rails/rails#54260

[tomoasleep]

Thank you for providing references.

Could you add a comment to this code about this issue? I want to make sure we don't forget to remove the version constraint when we update dependency version of activerecord.

[atm-snag2]

I added a comment.

[tomoasleep]

Thx!

[Copilot]

Pull Request Overview

Adds a development dependency constraint for concurrent-ruby to prevent incompatible versions.

• Introduces concurrent-ruby as a dev dependency with an upper bound < 1.3.5

Comments suppressed due to low confidence (1)

graphql-kaminari_connection.gemspec:35

• If concurrent-ruby is required by the gem at runtime, it should be added with spec.add_dependency instead of add_development_dependency so production installs include it.

spec.add_development_dependency 'concurrent-ruby', '< 1.3.5'

[Copilot]

[nitpick] Consider using a pessimistic version constraint (e.g., ~> 1.3.0) instead of a strict < 1.3.5 bound for consistency with other dependencies.

Suggested change

	spec.add_development_dependency 'concurrent-ruby', '< 1.3.5'
	spec.add_development_dependency 'concurrent-ruby', '~> 1.3.0'