-
Notifications
You must be signed in to change notification settings - Fork 6
Introduce qlty #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce qlty #43
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Introduces integration with qlty to publish and display code coverage and maintainability metrics.
- Adds JSON coverage formatter configuration via SimpleCov.
- Adds qlty coverage upload job in GitHub Actions and corresponding badges to the README.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/spec_helper.rb | Adds MultiFormatter including JSON and HTML formatters for coverage output. |
| graphql-kaminari_connection.gemspec | Adds simplecov_json_formatter as a development dependency. |
| README.md | Adds Maintainability and Code Coverage badges from qlty. |
| .github/workflows/test.yml | Adds a separate qlty job to run tests and upload coverage JSON. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
0d804c6 to
6fc1726
Compare
6fc1726 to
cae550b
Compare
cae550b to
0802b6f
Compare
wataru86
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What
How
simplecov_json_formatterWhy
REF