IWF-465: Initial search attributes #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwolczynski
requested review from
ktrops,
mixydubs,
samuel27m,
N-give and
stevo89519
samuel27m
reviewed
Mar 21, 2025
| val_type = sa_types[initial_sa_key] | ||
| new_sa = SearchAttribute(key=initial_sa_key, value_type=val_type) | ||
| is_val_correct_type = False | ||
| if val_type == SearchAttributeValueType.INT: |
There was a problem hiding this comment.
I don't know much Python, but could this be whole block with a switch type statement? Unsure if it's a feature available in Python though
There was a problem hiding this comment.
I wish it could! https://www.datacamp.com/tutorial/python-switch-case
It's available in 3.10+
There was a problem hiding this comment.
We'd need to drop the 3.9 support
https://github.com/indeedeng/iwf-python-sdk?tab=readme-ov-file#requirements
There was a problem hiding this comment.
Makes sense! Thank you 💯
Yes, I think it's best to keep the 3.9 support for now. We can do one big refactor a some point if we decide that the features are worth it. I don't think it's worth it just for the match feature 👍
samuel27m
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30