Skip to content

Escape forward slashes when using useScriptElementForInitialPage #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pascalbaljet merged 1 commit into from
Dec 12, 2025
+6 −6
Merged

Escape forward slashes when using useScriptElementForInitialPage #2751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/createInertiaApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export default async function createInertiaApp<SharedProps extends PageProps = P
createElement('script', {
'data-page': id,
type: 'application/json',
dangerouslySetInnerHTML: { __html: JSON.stringify(initialPage) },
dangerouslySetInnerHTML: { __html: JSON.stringify(initialPage).replace(/\//g, '\\/') },
}),
createElement('div', { id }, reactApp as ReactElement),
)
Expand Down
2 changes: 1 addition & 1 deletion packages/svelte/src/createInertiaApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export default async function createInertiaApp<SharedProps extends PageProps = P

return {
body: useScriptElementForInitialPage
? `<script data-page="${id}" type="application/json">${JSON.stringify(initialPage)}</script><div data-server-rendered="true" id="${id}">${html}</div>`
? `<script data-page="${id}" type="application/json">${JSON.stringify(initialPage).replace(/\//g, '\\/')}</script><div data-server-rendered="true" id="${id}">${html}</div>`
: `<div data-server-rendered="true" id="${id}" data-page="${escape(JSON.stringify(initialPage))}">${html}</div>`,
head: [head, css ? `<style data-vite-css>${css.code}</style>` : ''],
}
Expand Down
2 changes: 1 addition & 1 deletion packages/vue3/src/createInertiaApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export default async function createInertiaApp<SharedProps extends PageProps = P
h('script', {
'data-page': id,
type: 'application/json',
innerHTML: JSON.stringify(initialPage),
innerHTML: JSON.stringify(initialPage).replace(/\//g, '\\/'),
}),
h('div', {
id,
Expand Down
2 changes: 1 addition & 1 deletion tests/app/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ app.get('/ssr/page-with-script-element', (req, res) =>
inertia.renderSSR(req, res, {
component: 'SSR/PageWithScriptElement',
props: {
message: 'Hello from script element!',
message: 'Hello from script element! Escape </script>.',
},
}),
)
Expand Down
4 changes: 2 additions & 2 deletions tests/ssr.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,14 @@ test.describe('SSR', () => {

expect(html).toContain('data-page="app"')
expect(html).toContain('<script data-page="app" type="application/json">')
expect(html).toContain('Hello from script element!')
expect(html).toContain('Hello from script element! Escape <\\/script>.')

await page.goto('/ssr/page-with-script-element')
const scriptContent = await page.locator('script[data-page="app"]').textContent()
expect(JSON.parse(scriptContent || '')).toMatchObject({
component: 'SSR/PageWithScriptElement',
props: {
message: 'Hello from script element!',
message: 'Hello from script element! Escape </script>.',
},
})
})
Expand Down