[IM] Add description/type for BIRDv3 #923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option for BIRD3.
I am not sure of the best approach for making BIRD3 templates, e.g., if the existing templates should be adapted, or to make a new set of templates for bird3. e.g. to copy the bird2 templates to /resources/views/api/v4/router/server/bird3.
Might be cleaner going forwards if the config for bird3 starts to diverge significantly from v2, to avoid a lof of complex logic in the template "if version 3 then.. else... " and prevent unexpected breakages of one version when updating the template for the other version.
Arouteserver has some initial support for bird3 configs https://github.com/pierky/arouteserver/tree/master