Fix the crash caused by out-of-bounds writes in survival mode (with lua)#109
Open
userwljs wants to merge 1 commit intoinfclass:kaffeine/survivalfrom
Open
Conversation
…ontroller::SurvivalAddBot
Author
|
Hi @Kaffeine, If you have time, could you please take a look at this PR? Thanks for your work on this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug manifests as follows: when a Witch is present and Lua is used, a rare SIGILL occurs in Debug builds, while SIGSEGV occurs frequently in Release builds.
teeworlds-infclassR/src/game/server/infclass/ic_gamecontroller.cpp
Line 2773 in 0f94bcb