Skip to content

Conversation

@shadielfares
Copy link

GITHUB PR TEMPLATE + WORKFLOWS

* Fixed: Slicer metadata not properly locating sliced files

* Fixed: Saving to external output directory

* Fixed metadata.json segment file paths

* Fixed Run, Circuitize File Imports

Slice, Circuitize, Run, Prove, Verify all functional with external directories

* Added E2E Test (#10)

* Added GA, Modified Circuitizer File Paths

* Added Testing{

* Fix 14 (#15)

* Fixed #14

* Update test.yml

* Update test.yml
Added additional test + fixed slicing adding more segment directories than neccesary
@shadielfares shadielfares requested a review from Copilot August 25, 2025 14:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub workflow templates and comprehensive infrastructure for ONNX model analysis, slicing, and zero-knowledge proof generation. The changes introduce a complete pipeline for processing neural network models with support for multiple proof systems (EZKL, JSTProve) and include E2E testing capabilities.

  • Adds comprehensive ONNX model analysis and slicing infrastructure with metadata generation
  • Implements runners for multiple ZK proof systems (EZKL, JSTProve, DeepProve) with support for both whole model and sliced inference
  • Introduces extensive testing framework with E2E tests and model generation utilities

Reviewed Changes

Copilot reviewed 21 out of 28 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
testing/core/e2e_tests/test_e2e.py E2E test framework for the complete kubz workflow from slicing to verification
src/utils/onnx_utils.py ONNX utility functions for model manipulation and metadata handling
src/utils/onnx_analyzer.py Comprehensive ONNX model analyzer for extracting detailed model metadata
src/utils/model_generator.py Test model generation utilities for creating various neural network architectures
src/utils/model_analyzer.py PyTorch model analyzer for extracting activation functions and layer information
src/templates/report_template.html Interactive HTML template for neural network visualization reports
src/runners/runner_utils.py Shared utilities for model runners including memory monitoring and input preprocessing
src/runners/onnx_runner.py ONNX model inference runner supporting both whole and sliced model execution
src/runners/model_runner.py PyTorch model runner with support for segmented inference
src/runners/jstprove_runner.py JSTProve integration for ZK proof generation and verification
src/runners/ezkl_runner.py EZKL integration with comprehensive proof workflow support
src/runners/deepprove_runner.py DeepProve runner skeleton for future ZK proof system integration
src/onnx_slicer.py ONNX model slicing implementation for creating model segments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shadielfares shadielfares marked this pull request as ready for review August 27, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants